D12123: [UDisks] Optimize several property checks
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Apr 12 10:12:36 UTC 2018
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> udisksdevice.cpp:840
> {
> - return propertyExists("MountPoints") && !qdbus_cast<QByteArrayList>(prop("MountPoints")).isEmpty();
> + QVariant mountPoints = prop(QStringLiteral("MountPoints"));
> + return mountPoints.isValid() && !qdbus_cast<QByteArrayList>(mountPoints).isEmpty();
const
REPOSITORY
R245 Solid
BRANCH
qstringliteral
REVISION DETAIL
https://phabricator.kde.org/D12123
To: bruns, #frameworks, broulik
Cc: broulik, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180412/7fae8143/attachment.html>
More information about the Kde-frameworks-devel
mailing list