D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Apr 12 10:05:44 UTC 2018


broulik added inline comments.

INLINE COMMENTS

> udisksdevicebackend.cpp:147
> +                if (size.isValid() && size.toInt() != 0) {
> +                    m_propertyCache.insert(QStringLiteral("Size"), size);
> +                }

So when size is unknown it will always query it as you will never have a Size in the `m_propertyCache`?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D12125

To: bruns
Cc: broulik, #frameworks, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180412/1dce9a85/attachment.html>


More information about the Kde-frameworks-devel mailing list