D12124: Avoid creating duplicate property entries in the cache

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Apr 11 22:31:08 UTC 2018


bruns created this revision.
bruns added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  Properties are associated with a specific interface, although the Solid
  UDisks2 backend merges properties from all interfaces into a single
  namespace.
  Fortunately most properties have either unique names accross interfaces,
  or are consistent (e.g. "Size" in org.fd.UDisks2.{Block,Partition}), thus
  this poses no problem in practice.
  QMap<>::unite(other) behaves like QMap<>::insertMulti(item), i.e. the
  map may contain multiple values per key, while QMap<>::insert(item)
  updates the value for existing keys.

TEST PLAN
  make
  solid-hardware list details

REPOSITORY
  R245 Solid

BRANCH
  unique_properties

REVISION DETAIL
  https://phabricator.kde.org/D12124

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevicebackend.cpp

To: bruns, #frameworks
Cc: michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180411/a9e9b736/attachment.html>


More information about the Kde-frameworks-devel mailing list