D12114: Revive 'Description' property
Michael Heidelbach
noreply at phabricator.kde.org
Wed Apr 11 14:19:43 UTC 2018
michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.
REVISION SUMMARY
`Property::Description` did not make it into KF5, `Property::Comment` is used instead .
This patch revives 'Description' as it is more specific and to avoid confusion.
- Create tests for epub, odf and office documents
- Ensure 'Comment' is no longer provided
- Make tests pass
TEST PLAN
make test
REPOSITORY
R286 KFileMetaData
BRANCH
desc_instead_comm (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12114
AFFECTED FILES
autotests/CMakeLists.txt
autotests/epubextractortest.cpp
autotests/epubextractortest.h
autotests/odfextractortest.cpp
autotests/odfextractortest.h
autotests/office2007extractortest.cpp
autotests/office2007extractortest.h
autotests/samplefiles/test.epub
src/extractors/epubextractor.cpp
src/extractors/odfextractor.cpp
src/extractors/office2007extractor.cpp
src/properties.h
src/propertyinfo.cpp
To: michaelh, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180411/8544061c/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list