D12016: [ktexteditor] much faster positionFromCursor

[Jaime Torres Amate]

jtamate marked an inline comment as done.
jtamate added a comment.




INLINE COMMENTS

> mwolff wrote in kateviewaccessible.h:191
> I know the old code used int already, but shouldn't this better be a quint64 as it's a file offset?

All the methods of QAccesibeTextInrface <http://doc.qt.io/qt-5/qaccessibletextinterface.html> expect an int.
What should be done if the document has more data than INT_MAX?
deactivate the class and show a warning? In any case, I think this is out of scope of this patch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12016

To: jtamate, #kate, cullmann, #frameworks
Cc: mwolff, brauch, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180411/c083f209/attachment.html>