D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Apr 10 02:38:25 UTC 2018


bruns added a comment.


  In D5784#243432 <https://phabricator.kde.org/D5784#243432>, @adridg wrote:
  
  > The question is mostly: does the existing (complicated) code do anything that QStorageInfo doesn't? Because switching to QStorageInfo gives us the functionality on FreeBSD for free (even if it's not useful because we'll never have btrfs).
  
  
  My opinion is to scrap the function completely, on *BSD **and** on Linux. //Iff// there ever is a need, one can add it back, or just call QStorageInfo directly wherever it is used.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D5784

To: tcberner, #freebsd, poboiko, bruns
Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180410/d87e0788/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list