D11828: Simplify orPostingIterator and make it faster

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Apr 9 15:47:19 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in orpostingiterator.cpp:71
> Newbie question: Does std::unique_ptr make sense here?

When writing from scratch today, yes.
But this would not disallow nullptr (`std::make_unique<PostingIterator>(nullptr)` is fully valid)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180409/57d1554f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list