D12064: Don't alter memory management to hide an item

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The original owner of a graphics item is the declarative applet script which
  is owned and deleted by the applet.
  
  Reparenting the containmentquickitem to the containment doesn't really
  solve anything useful, we were originally effectively owned by the
  containment(an applet subclass) not the view anyway.
  
  This code also accidentally moves the destruction of the applet from being in
  ::~Applet to being in ::~QObject of the relevant containment. This
  causes a big problem if the AppletQuickItem tries to access the applet
  in it's own destructor. The applet object still exists, but use of
  Applet member variables is not valid.
  
  The new preloading code does this, leading to a crash.
  
  BUG: 391642

TEST PLAN
  Changed desktop to folder twice
  Changed activities twice

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12064

AFFECTED FILES
  src/plasmaquick/containmentview.cpp

To: davidedmundson, #plasma
Cc: #frameworks, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180409/82129fec/attachment.html>