KNewStuff - CMake targets hardcoding paths
Christophe Giboudeaux
christophe at krop.fr
Sun Apr 8 09:48:17 UTC 2018
Hi,
On dimanche 8 avril 2018 04:30:15 CEST Ben Cooksley wrote:
> Hi all,
>
> On Windows the Binary Factory has recently struck an issue with
> KNewStuff where the paths supplied in the newstuffqmlplugin target it
> installs are hardcoded.
>
> This can be seen at the bottom of
> https://binary-factory.kde.org/view/Windows%2032-bit/job/Peruse_Nightly_win3
> 2/12/consoleText
>
> Could someone please take a look and change it so that this is
> relative like all the other Frameworks (and other parts of KNewStuff)
>
There are different issues with different solutions:
- The newstuffqmlplugin is installed in the wrong dir. If it's a public
library, it should be installed elsewhere.
This brings the first problem: there are no headers installed.
- If the library is not supposed to install headers, it also shouldn't install
CMake config files.
Second problem then: removing the CMake stuff may be considered SIC (even it
never was usable).
(the knewstuffquick is a runtime check in the Peruse code)
Christophe
More information about the Kde-frameworks-devel
mailing list