D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

[David Faure]

dfaure added a comment.


  This calls for unittests. UndoManager has unittests here in kio, but if this requires kio_desktop then the test needs to be where kio_desktop is.

INLINE COMMENTS

> copyjob.cpp:2095
>          ++m_processedFiles;
> -        emit q->copyingDone(q, *m_currentStatSrc, finalDestUrl(*m_currentStatSrc, dest), QDateTime() /*mtime unknown, and not needed*/, true, true);
> +        // Bug 391606: finalDestUrl needs the resolved URL to slook up the trash file name
> +        // which is why we're passing m_currentSrcURL instead of m_currentStatSrc to it

slook?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11987

To: broulik, #frameworks, dfaure
Cc: michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180407/7da68315/attachment.html>