D12005: Fix merging of terms in the AdvancedQueryParser
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sat Apr 7 01:26:57 UTC 2018
bruns created this revision.
bruns added reviewers: Baloo, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.
REVISION SUMMARY
The code merged compatible terms only if the left hand side was a list of
subterms (i.e. it worked for "a AND b AND (c AND d)", but not
"b AND (c AND d)"). Instead of duplicating code, just use the
Term(Term, Operation, Term) constructor, which handles merging.
REPOSITORY
R293 Baloo
BRANCH
baloo_term_cleanup_2
REVISION DETAIL
https://phabricator.kde.org/D12005
AFFECTED FILES
autotests/unit/lib/advancedqueryparsertest.cpp
src/lib/advancedqueryparser.cpp
To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180407/cb677697/attachment.html>
More information about the Kde-frameworks-devel
mailing list