D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

Fabian Kosmale noreply at phabricator.kde.org
Fri Apr 6 23:15:04 UTC 2018


fabiank created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
fabiank requested review of this revision.

TEST PLAN
  Run the steps described in the testplan of D12001 <https://phabricator.kde.org/D12001>. Without the patch, the
  warning "Illegal icon group: 7" gets displayed, as Okular uses User icons.
  Applying the patch fixes this; unit tests still run without failure.

REPOSITORY
  R302 KIconThemes

BRANCH
  fixWarning

REVISION DETAIL
  https://phabricator.kde.org/D12002

AFFECTED FILES
  src/kiconloader.cpp

To: fabiank
Cc: #frameworks, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180406/949232bd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list