D11907: advancedqueryparsertest: Add more tests

Michael Heidelbach noreply at phabricator.kde.org
Fri Apr 6 19:15:20 UTC 2018


michaelh marked 4 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in advancedqueryparsertest.cpp:264
> Adds no information, just use QString() here (and twice below)

This test fails. "no optimization" serves as a flag, that it's expected to fail and as message why. See lines 217-219. That's why I thought of dropping it, because  D11826 <https://phabricator.kde.org/D11826> does not make it pass.

If we drop this test the `failmessage` column can be removed.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180406/f91800f3/attachment.html>


More information about the Kde-frameworks-devel mailing list