D11907: advancedqueryparsertest: Add more tests

[Stefan Brüns]

bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> advancedqueryparsertest.cpp:229
> +    QTest::addColumn<QString>("failmessage");
> +    const QString nofail;
> +    QString searchInput;

remove

> advancedqueryparsertest.cpp:231
> +    QString searchInput;
> +    searchInput = QStringLiteral("a AND b AND c AND d");
> +    QTest::newRow(qPrintable(searchInput))

Remove the searchInput temporary and ...

> advancedqueryparsertest.cpp:233
> +    QTest::newRow(qPrintable(searchInput))
> +        << searchInput
> +        << Term{Term::And, QList<Term>{

... use the QStringLiteral here

> advancedqueryparsertest.cpp:253
> +        }}
> +        << nofail
> +        ;

Just `<< QString()`

> advancedqueryparsertest.cpp:264
> +        }}
> +        << QStringLiteral("no optimization")
> +        ;

Adds no information, just use QString() here (and twice below)

REPOSITORY
  R293 Baloo

BRANCH
  advancedqueryparsertest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180406/089970bf/attachment.html>