D11907: advancedqueryparsertest: Add more test

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in advancedqueryparsertest.cpp:255
> What about this one? Drop it?

I think it should stay as it exercises the stack in the query parser

Pseudocode:

  s[0] = a, AND
  s[1] = b, AND
  t = construct (c AND d)
  t = Term( s[1].term, t, s[1].op)  
  t = Term( s[0].term, t, s[0].op)

> advancedqueryparsertest.cpp:290
> +    // a && b && c && d can be combined into one AND term with 4 subterms
> +    QTest::addRow("&&")
> +        << (Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains}

Use "a && b && c && d", makes grepping in case of failure easier?

> advancedqueryparsertest.cpp:305
> +    // (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D)
> +    QTest::addRow("(&&) AND (||)")
> +        << ((Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains}

dito, "(a && b) && (c || d)"

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180405/968fefcb/attachment.html>