D11907: advancedqueryparsertest: Add more test

Michael Heidelbach noreply at phabricator.kde.org
Thu Apr 5 12:14:44 UTC 2018


michaelh added a comment.


  With this D11826 <https://phabricator.kde.org/D11826> makes a difference. In terms of comprehension I'm also almost there.
  `testNestedParentheses` still has some value as it tests nested parentheses more extensively than the one already there.
  
  Unless you have more comments, I suggest to land these tests before D11826 <https://phabricator.kde.org/D11826>, rebase  D11826 <https://phabricator.kde.org/D11826> and change the respective `failmessage`s to an empty string.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180405/dfa0d99a/attachment.html>


More information about the Kde-frameworks-devel mailing list