D11907: advancedqueryparsertest: Add optimization test

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Apr 4 21:02:23 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> advancedqueryparsertest.cpp:228
> +    const QString nofail;
> +    QString phrase;
> +    phrase = QStringLiteral("a AND b AND c AND d");

better use a different name, phrase has a special meaning, i.e. Baloo:EngineQuery:Phrase

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180404/a97495f4/attachment.html>


More information about the Kde-frameworks-devel mailing list