D11924: [WIP] Add "SkipSwitcher" to API

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I'm not sure whether we can add elements to the states.

INLINE COMMENTS

> netwininfotestwm.cpp:432
>      const QByteArray skipTaskbar      = QByteArrayLiteral("_NET_WM_STATE_SKIP_TASKBAR");
> +    const QByteArray skipSwitcher     = QByteArrayLiteral("_NET_WM_STATE_SKIP_SWITCHER");
>      const QByteArray keepAbove        = QByteArrayLiteral("_NET_WM_STATE_ABOVE");

This needs a KDE prefix as it's a KDE specific extension

> netwm_def.h:502
>          **/
> -        DemandsAttention = 1u << 11
> +        DemandsAttention = 1u << 12
> +

You cannot change enum values. Please add the new one afterwards

> atoms_p.h:136
>      ENUM(_NET_WM_STATE_DEMANDS_ATTENTION),
> +    ENUM(_NET_WM_STATE_SKIP_SWITCHER),
>  

Also a KDE prefix is needed

> netwm.cpp:26
>  
> -//#define NETWMDEBUG
> +// #define NETWMDEBUG
>  #include "netwm.h"

Unrelated change

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: graesslin, apol, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180404/94f87b73/attachment.html>