D11882: extractortest: Use built executable instead of installed

Alexey Min noreply at phabricator.kde.org
Wed Apr 4 09:41:03 UTC 2018


alexeymin added inline comments.

INLINE COMMENTS

> filemetadatawidgettest.cpp:60
> +    qputenv("PATH", qPrintable(QStringLiteral("%1;%2").arg(np).arg(op)));
> +    #endif
> +    const auto extractorPath = QDir( QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath();

Should probably use `QDir::listSeparator()` instead of this `#ifdef` logic

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180404/f4f2e86d/attachment.html>


More information about the Kde-frameworks-devel mailing list