D11891: Fix crashes in NotifyByAudio when closing applications

[René J.V. Bertin]

rjvbb added a comment.


  So the difference here is that `finishNotification` isn't called if `notification == nullptr`, with the crucial difference probably being the fact that `m` isn't added multiple times to the list of reusable items?
  
  Why isn't that logic part of `finishNotification()`? IOW, is there a valid reason for finishNotification to be called with a NULL `notification` argument but `m` that hasn't yet been moved from m_notifications to m_reusablePhotons?

INLINE COMMENTS

> notifybyaudio.cpp:148-150
> +        // since stoping a mediaobject means it wont't emit finished() *BUT*
> +        // since the finished signal is a queued connection in phonon it can happen
> +        // that the playing had already finished and we just had not got the signal yet

Slightly better English:

  // since stopping a mediaobject means it wont't emit finished(). However,
  // we can receive pending finished() signals that were already emitted after
  // playback completed: phonon uses a queued connection for these signals.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann
Cc: rjvbb, mpyne, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180403/8332c7f9/attachment.html>