D8043: KDirWatch : make methods virtual

René J.V. Bertin noreply at phabricator.kde.org
Fri Sep 29 00:57:11 UTC 2017


rjvbb added a comment.


  In a (big) nutshell: https://phabricator.kde.org/D7995.
  
  KDevelop currently uses a single KDirWatch per open project that is fed with a single `addDir` call which adds all folders under the project directory (and all files, which it shouldn't).
  This is fine on Linux when the Inotify method is used, but can become very costly when the QFSWatch method is used (always, on Mac). The actual import of the project directory is done on a background thread (1 per project), and it would make sense to let it feed individual directories to the KDirWatch at the same time. The KDirWatch signals are still received and handled by the main thread.
  
  Using a KDirWatch per thread would still mean that they can be accessing the shared QFSW instance concurrently.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8043

To: rjvbb, #frameworks, mwolff, dfaure
Cc: dfaure, mwolff, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170929/631ce9c7/attachment.html>


More information about the Kde-frameworks-devel mailing list