D8043: KDirWatch : make methods virtual

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.


  In addition to being BIC, this is not the way to add thread safety. Either the class should be threadsafe (and then it should use mutexes internally) or it doesn't need to be threadsafe (and that can just be documented).
  Why not create one KDirWatch per thread?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8043

To: rjvbb, #frameworks, mwolff, dfaure
Cc: dfaure, mwolff, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170928/bea39007/attachment.html>