D8046: [FrameSvgItem] Iterate child nodes properly

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Sep 28 20:47:09 UTC 2017


broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Documentation says "Children are stored internally as a linked list, so iterating over the children via the index is suboptimal."

TEST PLAN
  Verified that it doesn't crash and the number of repositioned nodes stays identical, ie. I didn't miss one.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8046

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170928/fb07aeab/attachment.html>


More information about the Kde-frameworks-devel mailing list