D8029: Use edit-delete icon for destructive discard action

David Edmundson noreply at phabricator.kde.org
Thu Sep 28 15:09:50 UTC 2017


davidedmundson added a comment.


  I think it's important that KStandardGuiItem::discard matches QDialogButtonBox::Discard
  
  You've cited what Qt does, but we override it in kstyle.cpp:374 with dialog-cancel
  
  If we go with this (and I really don't object) we should adjust KStyle too.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8029

To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson
Cc: cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170928/101d2658/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list