D8002: Improve DesktopFileParser heuristic for finding old-style service desktop entries

[Michael Pyne]

mpyne created this revision.
mpyne added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  When we adopted JSON plugin metadata for services, we also included compatibility code so that we could continue to load the older Desktop Entry format for KDE services (looks to me that we convert it on the fly so that the application code can just use everything as if it were from the JSON-based service metadata).
  
  To make sure we find any legacy .desktop files for service types, we have to know their name based on their service type, so that we can load the .desktop file and add their metadata to the options we maintain for each service type definition.  IIRC we could use KSycoca in kdelibs4 to find the right service type metadata, even without knowing the source desktop file entry, but we don't have KSycoca anymore so we have to look up likely .desktop files ourselves.
  
  The heuristic we currently use maps any `/` characters to a `-`, so that a request for something like `KWin/Effect` service types would map to `kservicetypes5/kwin-effect.desktop` when searching for the .desktop file.
  
  This heuristic doesn't find all likely desktop entry candidates though.  In particular it fails for `KWin/Effect` (which is really at `kservicetypes5/kwineffect.desktop`).
  
  This change modifies the legacy lookup code path to search first for the existing heuristic, and if that fails to search by an additional heuristic that does the exact same thing but mapping `/` to nothing instead.
  
  See also bug 384037 <https://bugs.kde.org/show_bug.cgi?id=384037>

TEST PLAN
  Running System Settings and playing with the KWin Desktop Effects KCMs no longer spams the console with warnings about missing service types.  Nothing else in the desktop seems to have been broken either.  But I haven't found a much better way to test.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8002

AFFECTED FILES
  src/lib/plugin/desktopfileparser.cpp

To: mpyne, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170927/ac22ce0d/attachment.html>