D7884: - Increase size of trailing mark

Anthony Fieroni noreply at phabricator.kde.org
Sun Sep 24 10:18:20 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> katerenderer.cpp:272
> +
> +    pen.setWidthF(spaceWidth() / (3.5 - (m_markerSize * 0.5)));
>      pen.setCapStyle(Qt::RoundCap);

You can move width calculation in setmarkersize to safe unwanted calculations.

> katerenderer.h:406
>      bool m_showSpaces;
> +	uint m_markerSize;
>      bool m_showNonPrintableSpaces;

Strange indent

> kateconfig.cpp:758
>  
> +void KateDocumentConfig::setMarkerSize(uint markerSize) {
> +    if (m_markerSize == markerSize) {

function()
{
}

> kateconfig.h:242-243
>  
> +	void setMarkerSize(uint markerSize);
> +	uint markerSize() const;
> +

indent

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: anthonyfieroni, dhaumann, sars, #frameworks, cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170924/269755d6/attachment.html>


More information about the Kde-frameworks-devel mailing list