D7926: Remove pf.path() from container before the reference got screwed up by it.remove()

Christian Ehrlicher noreply at phabricator.kde.org
Thu Sep 21 17:13:38 UTC 2017


chehrlic created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  With https://phabricator.kde.org/R293:a75db7aedfcd356b027774e0dc156c334d4cb869 I introduced a crash when removing a watched
  directory. The Problem is that it.remove() invalidates the reference to PendingFile which
  leads to a crash... :(
  I found no bugreport about this on bugs.kde.org until now.

TEST PLAN
  Remove a directory, baloo should never crash when removing a watched directory

REPOSITORY
  R293 Baloo

BRANCH
  fix_crash_pendingfilequeue

REVISION DETAIL
  https://phabricator.kde.org/D7926

AFFECTED FILES
  src/file/pendingfilequeue.cpp

To: chehrlic
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170921/1af7b6ce/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list