D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 19757.
chinmoyr marked an inline comment as done.
chinmoyr added a comment.


  - separated FdReceiver and FdSender
  - KMSgHdr -> FDMessageHeader and KSockaddrUn -> SocketAddress and moved them to private header
  - removed `stopListening()` method. Qt can handle `m_readNotifier`'s deletion
  
  Question : Is it strange that kauth directory appears in this commit? And shall I rename `isValid()` in `FdReceiver` to `isListening()`?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6709?vs=18502&id=19757

BRANCH
  sharefd

REVISION DETAIL
  https://phabricator.kde.org/D6709

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/kauth/fdsender.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, thiago, #frameworks, dfaure
Cc: dfaure, davidedmundson, elvisangelaccio, shortstheory
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170921/9f8774e6/attachment.html>