D7898: Only send OutputConfig sendApplied / sendFailed to the right resource

David Edmundson noreply at phabricator.kde.org
Wed Sep 20 20:32:05 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  I don't understand the original logic.
  s_allResources contains /every/ resource, not just outputconfigurations.
  
  Sending org_kde_kwin_outputconfiguration_send_applied to a wl_surface (for example),
  results in an error.
  
  The reason kwin doesn't currently crash is because we don't actually send
  applied/failed after setting outputs. (which is another bug)

TEST PLAN
  The existing unit test still passes.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7898

AFFECTED FILES
  src/server/outputconfiguration_interface.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170920/4ef558a7/attachment.html>


More information about the Kde-frameworks-devel mailing list