D7859: KMessageBox: Use question mark icon for question dialogs

Henrik Fehlauer noreply at phabricator.kde.org
Sun Sep 17 10:08:25 UTC 2017


rkflx created this revision.
rkflx added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Besides `Information`, `Warning` and `Critical`, the `QMessageBox::Icon`
  enum supports icons of type `Question`. Instead of falling back to an
  "information" icon, use a "question mark" icon for every
  `KMessageBox::question*()`.
  
  Note: Using the Oxygen icon set still displays an "information" icon
  (may need investigation).

TEST PLAN
  - `kmessageboxtest` now shows question mark icon for some dialogs
  - cursory look at lxr suggest most usage is a proper question indeed
  - question mark icon supported in Breeze and Adwaita icon set

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7859

AFFECTED FILES
  src/kmessagebox.cpp

To: rkflx, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170917/4fdaebac/attachment.html>


More information about the Kde-frameworks-devel mailing list