D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM
Christophe Giboudeaux
noreply at phabricator.kde.org
Fri Sep 15 11:02:36 UTC 2017
cgiboudeaux added a comment.
-1. They don't match the ECM coding style and code quality (doc, license, endif(), pkgconfig...)
And :
> kdelibs4support/cmake/modules/FindGLIB2.cmake
> ecm/attic/modules/FindGLIB2.cmake
These two are there for legacy purpose.
> phonon/cmake/FindGLIB2.cmake
> polkit-qt/cmake/modules/FindGLIB2.cmake
these modules don't use ECM to build.
> kdelibs4support/cmake/modules/FindPulseAudio.cmake
> ecm/attic/modules/FindPulseAudio.cmake
> phonon/cmake/FindPulseAudio.cmake
same thing here.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170915/8a67aad9/attachment.html>
More information about the Kde-frameworks-devel
mailing list