D7827: Syntax indexer: Catch invalid a-Z/A-Z ranges in regexps

Dominik Haumann noreply at phabricator.kde.org
Thu Sep 14 20:48:32 UTC 2017


dhaumann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Motivated by incorrect regular expressions of the form [a-zA-z] or [a-Z], this patch extends the highlighting indexer to check for this kind of errors. This, however, is only a heuristic, so theoretically, we may have false positives. This is not an issue so far, though. In fact, this check detects two more issues, which are fixed with this change as well.

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7827

AFFECTED FILES
  data/syntax/bitbake.xml
  data/syntax/haml.xml
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, #framework_syntax_highlighting, gregsteuck, vkrause, cullmann
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170914/e4692a0f/attachment.html>


More information about the Kde-frameworks-devel mailing list