D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM
Jonathan Marten
noreply at phabricator.kde.org
Thu Sep 14 16:45:36 UTC 2017
marten created this revision.
Restricted Application added projects: Frameworks, Build System.
REVISION SUMMARY
These modules are used in a number of places within Frameworks, Plasma and dependencies:
FindGLIB2:
plasma-desktop/applets/kimpanel/cmake/FindGLIB2.cmake
kdelibs4support/cmake/modules/FindGLIB2.cmake
ecm/attic/modules/FindGLIB2.cmake
phonon/cmake/FindGLIB2.cmake
polkit-qt/cmake/modules/FindGLIB2.cmake
FindPulseAudio:
kdelibs4support/cmake/modules/FindPulseAudio.cmake
ecm/attic/modules/FindPulseAudio.cmake
phonon/cmake/FindPulseAudio.cmake
Apart from those in Phonon, each set is all the same apart from minor formatting differences.
These two modules will also be required by KMix when it is finally ported away from KDElibs4Support. Since these common files are used in multiple places, it makes sense to have them included in ECM instead of making local copies.
TEST PLAN
Built and installed ECM with these two modules added, configured KMix with KDELibs4Support removed.
GLIB2 and PulseAudio are found correctly using the modules installed by ECM.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
AFFECTED FILES
find-modules/FindGLIB2.cmake
find-modules/FindPulseAudio.cmake
To: marten, #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170914/51a193e5/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list