D7750: fix crash when more than one instances of ExtractorCollection are destructed

Anthony Fieroni noreply at phabricator.kde.org
Tue Sep 12 07:26:37 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> extractor.cpp:39-46
> +    if (d) {
> +        if (d->m_pluginLoader.isLoaded()) {
> +            d->m_pluginLoader.unload();
> +        } else {
> +            delete d->m_plugin;
> +        }
> +    }

Make a method to call it, here and in destructor to not have duplicate code.
Other looks good to me +1.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D7750

To: mgallien, #frameworks
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170912/4fdb9e2e/attachment.html>


More information about the Kde-frameworks-devel mailing list