D7580: Support loading by stream and restoring state on reload

[David Faure]

dfaure added a comment.


  In https://phabricator.kde.org/D7580#144518, @kossebau wrote:
  
  > When I read this initially, I guessed this method is just about the view state. But is also bound to data-pulling by the kpart, given that the default implementation explicitely calls openUrl() with the url stored in the datastream. Which might make sense for simple-to-use API with the non-stream use cases. But leaves out the stream-based data-pushing usage.
  
  
  It does indeed. Two incompatible features...
  
  I think all we need is for the part to remember that it opened the URL via the stream api, and add that to the data saved by saveState(). Then in restoreState() we can skip openUrl() when that bool is true. It'll be up to the caller to redo the openStream/writeStream/closeStream sequence.
  
  >   BTW: can you tell if Falkon will/does support kparts?
  
  It doesn't, and I don't think it will, but you can try to convince David Rosca ;)

REPOSITORY
  R383 SVGPart

REVISION DETAIL
  https://phabricator.kde.org/D7580

To: kossebau, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170910/e24da721/attachment.html>