D6831: Make use of kauth helper in methods of file ioslave

[David Faure]

dfaure added a comment.


  separate commits are easier to review, so that's fine

INLINE COMMENTS

> file.cpp:651
> +                        oflags = O_RDWR | O_APPEND;
> +                        openMode = QIODevice::ReadWrite | QIODevice::Append;
>                      } else {

why not share this with lines 633/635?

i.e. determine openMode once and for all, use it in both cases (as user, then as root)

> file_unix.cpp:603
> +                    // Some error occurred while we tried to symlink
> +                    error(KIO::ERR_CANNOT_SYMLINK, dest);                }
> +                return;

weird placement for '}', newline missing

REVISION DETAIL
  https://phabricator.kde.org/D6831

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170909/b0f63593/attachment-0001.html>