D7676: Added openService() method to KRunProxy

Mladen Milinkovic noreply at phabricator.kde.org
Tue Sep 5 09:00:40 UTC 2017


maxrd2 added a comment.


  In https://phabricator.kde.org/D7676#143033, @broulik wrote:
  
  > Well it is now "openService" calling "runApplication", that's inconsistent isn't it
  
  
  Yes, but it will start services that have Exec line though.
  Should i just rename the method to "openApplication" or "runApplication" ?
  
  Adding something like this wont change much it seems.
  
    if(!service->isApplication())
        KRun::runService(*service, QList<QUrl>(), nullptr) != 0;

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D7676

To: maxrd2, davidedmundson
Cc: broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170905/01bf731f/attachment.html>


More information about the Kde-frameworks-devel mailing list