D7580: Support loading by stream and restoring state on reload

David Faure noreply at phabricator.kde.org
Sun Sep 3 08:45:45 UTC 2017


dfaure added inline comments.

INLINE COMMENTS

> svgpart.cpp:118
> +    mStreamedData.clear();
> +    mItem = new QGraphicsSvgItem();
> +    mItem->setSharedRenderer(mRenderer);

Shouldn't mItem be deleted first?
You seem to rely on closeUrl() being called before the next openStream, but I don't remember that there's any guarantee for that to happen.
As I see it, it's *either* openUrl/closeUrl *or* openStream/writeStream/closeStream.

REPOSITORY
  R383 SVGPart

REVISION DETAIL
  https://phabricator.kde.org/D7580

To: kossebau, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170903/5a1597ea/attachment.html>


More information about the Kde-frameworks-devel mailing list