D6047: Support XDG v6

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> xdgshell_interface.cpp:40
> +    int attempt = 0;
> +    connect(pingTimer, &QTimer::timeout, q, [this, serial, attempt]() mutable {
> +        ++attempt;

what's the idea behind a mutable lambda?

> xdgshell_interface.h:458
> +     */
> +    void grabbed(KWayland::Server::SeatInterface *seat, quint32 serial);
> +

If it's something the client request, I would suggest a rename to grabRequested.

Could you please explain what "grab" is supposed to be?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma, graesslin
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170903/c2e2088b/attachment.html>