D7642: [ksycoca] Use QDateTime::currentDateTimeUtc

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Please use `arc diff` to upload patches so that context is available.
  
  m_now isn't used to detect changes, but to detect files "in the future".
  With your changes, the line if (mtime > m_now) will have to convert mtime to UTC first. It seems to me that you traded away one timezone conversion for thousands.
  Did you measure this?
  
  What we really need is QFileInfo::lastModifiedUtc(), assuming of course it would be able to do that without conversion...

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D7642

To: broulik, kde-frameworks-devel, dfaure
Cc: dfaure, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170903/06f5c4e0/attachment.html>