D8332: Added baloo urls into places model

[Renato Oliveira Filho]

renatoo added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesmodel.cpp:68
> Do we really want to keep that state? It's never reevaluated so could be a const if we keep it.
> 
> Asks the question of what happens if the setting changes at runtime though.

This code came from dolphin. And it does not check at runtime for changes on the configuration.

But yes I agree keep track of this will be nice, I thought about that while implementing it, but I did not find a way to track it in KConfing API documentation, and since dolphin do not do that, I understand that is not possible.

Do you know if that is possible? What do you suggest?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171031/c8c565c0/attachment.html>