D8545: kio: fix handling of KCookieAdvice::AcceptForSession

David Faure noreply at phabricator.kde.org
Sun Oct 29 15:34:00 UTC 2017


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcookiespolicyselectiondlg.h:54
>  
>          if (advice == QLatin1String ("accept"))
>              return KCookieAdvice::Accept;

Oh, nasty, the kconfig key is the untranslated english message...

OK with the fix, except that you probably meant remove(' ').
I don't even see how replace(' ') can compile, all replace overloads take at least two args, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8545

To: schwab, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171029/9c9c9401/attachment.html>


More information about the Kde-frameworks-devel mailing list