D7194: Detach before setting the d pointer

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @leinir I now completely gave up on the patch which tried to adapt to the non-shared EntryInternal. As the screenshot loading code and the payload download code  rely on the explicitly shared data to attach the fetched screenshots resp. update the download state, that would need some more redesign of logic to update the central EntryInternal storage and from there any interested viewer on that. Which I do not have the energy to try now. So by what I have seen I would vote for a revert as well. + some kf6 notes as you mentioned.
  
  @apol Was this patch created due to some bug seen, or perhaps only of the kind oh-that-seems-wrong-lets-be-nice-and-prevent-things? If the latter that might be handy :)
  
  Too bad that EntryInternal is exposed at all in the KNS API, while there is a public read-only wrapper to it. Seems the person designing this code initially should have named it EntryInternalReallyIMeanIt, but then descendants still might have just helped themselves as now for whatever they needed to ;)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7194

To: apol, leinir
Cc: sitter, kossebau, whiting, mutlaqja, broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171025/8ec6d37d/attachment-0001.html>