D8450: WIP: User can now hide an entire places group

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:297
> +    const QModelIndexList indexesGroup = placesModel->groupIndexes(placesModel->groupType(index));
> +
> +    for (const QModelIndex &idx : indexesGroup) {

m_disappearingItems.reserve(m_disappearingItems.count() + indexesGroup.count()) ?

> kfileplacesview.cpp:431
> +
> +    const KFilePlacesModel *placesModel = static_cast<const KFilePlacesModel *>(index.model());
> +    if (placesModel && placesModel->isPlaceGroupHidden(index)) {

index.model() can be null ?
otherwise it's not necessary to check "if (placesModel" as you use static_cast<...>

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171025/48a252b2/attachment.html>