D8427: Allow cross compiling resource file

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:33
>  if(BINARY_ICONS_RESOURCE)
> -    find_package(Qt5 NO_MODULE REQUIRED Core)
> -    add_executable(qrcAlias qrcAlias.cpp)
> -    target_link_libraries(qrcAlias PUBLIC Qt5::Core)
> +    if(CMAKE_CROSSCOMPILING AND QRCALIAS_EXECUTABLE)
> +        add_executable(qrcAlias IMPORTED GLOBAL)

Maybe some documentation on how to crosscompile it would be nice.
In fact it feels a bit random. How will the developer get this executable? It's not even installed...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8427

To: vpinon, apol, kfunk
Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171022/3e24c507/attachment.html>