D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7

[Michal Malý]

madcatx added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kio_smb.cpp:67
> While at it, I'd move `m_openFd` on its own line

It kind of violates my "change only as much as is needed" but the whole kio-smb source could probably use thorough reformatting anyway. Will do.

> elvisangelaccio wrote in kio_smb_browse.cpp:521
> Maybe call it `needsWorkaroundEEXIST()`?
> 
> Current name seems to imply the method //is// the workaround, while it just tells us whether we need the workaround.

Well, this method actually applies the workaround. The `m_enableEEXISTWorkaround` is set to true when the an affected libsmbclient library is detected.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D8387

To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: graesslin, z3ntu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171021/a59f1d5d/attachment-0001.html>