D8348: Add a section for removable devices

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:90
>  
> +    if (m_device.udi().isEmpty())
> +        updateDeviceInfo(m_bookmark.metaDataItem(QStringLiteral("UDI")));

Braces even on one line block.

> kfileplacesitem.cpp:328
> +{
> +    if (m_device.udi() != udi) {
> +        if (m_access) {

Early exit to not add unwanted indent.

  if (m_device.udi() == udi) {
      return false;
  }
  `

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg
Cc: anthonyfieroni, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171018/12416aba/attachment-0001.html>