D8355: Remove check for SNI hosts when chosing

David Edmundson noreply at phabricator.kde.org
Wed Oct 18 10:04:53 UTC 2017


davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Previous code (since very first commit) checked for both having a valid
  KSNI watcher as well as making sure there was a host available in order
  to choose which mode to use.
  
  This made some sense when Plasma 4 still had proper xembed support and
  one could turn SNIs off.
  
  The current code here is broken. On first creation we only check for a
  watcher - and only ends up checking for the host after it changes at
  runtime.
  
  Given it's not working properly, and the use case has changed it seems
  we can safely remove it.
  
  This removes a blocking DBus call on the property.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8355

AFFECTED FILES
  src/kstatusnotifieritem.cpp
  src/kstatusnotifieritem.h

To: davidedmundson
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171018/b932f546/attachment.html>


More information about the Kde-frameworks-devel mailing list