D8346: Remove blocking call in KStatusNotifierItem

David Edmundson noreply at phabricator.kde.org
Tue Oct 17 18:13:49 UTC 2017


davidedmundson added a comment.


  I've realised there's much more to do:
  
  The existing code has some super weird behaviour.
  
  Find there's an SNI watcher, but no host (i.e kded but no plasmashell) - that's fine, we don't check and create one anyway
  But if a host gets added/removed - then we check
  
  That makes no sense.
  
  IMHO, there's no point checking for hosts, if we have an SNI watcher, we're clearly on a system that supports SNIs, even if the view temporarily disappears.
  At which point I should just kill this code.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D8346

To: davidedmundson
Cc: xuetianweng, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171017/91218842/attachment.html>


More information about the Kde-frameworks-devel mailing list