D8332: Added baloo urls into places model

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesmodel.cpp:151
>  
> +    // if baloo is enabled, add new ulrs even if the bookbark file is not empty
> +    if (d->fileIndexingEnabled &&

typo: `bookbark`

> kfileplacesmodel.cpp:153
> +    if (d->fileIndexingEnabled &&
> +        root.metaDataItem(QStringLiteral("withBaloon")) != QStringLiteral("true")) {
> +

typo: `withBaloo`

> kfileplacesmodel.cpp:155
> +
> +        root.setMetaDataItem("withBaloon", "true");
> +        KFilePlacesItem::createSystemBookmark(d->bookmarkManager,

typo: `withBaloo`

> kfileplacesview.cpp:1321
> +{
> +    QString date = QString::number(year) + '-';
> +    if (month < 10) {

You can use the 'fill' feature of `QString::arg()` to achieve the same thing with cleaner code:

  QString("%1-%2-%3").arg(year).arg(month, 2, 10, 0).arg(day, 2, 10, 0);

> kfileplacesview.cpp:1344
> +
> +    if (path.endsWith(QLatin1String("documents"))) {
> +        searchUrl = searchUrlForType(QStringLiteral("Document"));

You should probably match by `/documents` so that you don't match invalid paths (`search:/foodocuments`)

> kfileplacesview.cpp:1360
> +{
> +    static const QString jsonQuery("{\"dayFilter\": 0,\
> +                                     \"monthFilter\": 0, \

use `QStringLiteral` for `jsonQuery`, then it won't have to be static

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: dvratil, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171017/4cc50c3e/attachment.html>